Fix file attribute in ListTestsAsXml for abstract class inheritance #6278
+35
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joteejotee
force-pushed
the
fix/6097-testclass-file-attribute
branch
from
0e70ea0 to
a5875eb
Compare
|
💡 Note: Although GitHub UI shows a merge conflict, the branch is already rebased onto upstream/10.5 and contains only a single clean commit. Please let me know if any adjustments are needed! |
| @@ -12,11 +12,11 @@ require_once __DIR__ . '/../../../bootstrap.php'; | |||
|
|
|||
| (new PHPUnit\TextUI\Application)->run($_SERVER['argv']); | |||
| --EXPECTF-- | |||
| PHPUnit %s by Sebastian Bergmann and contributors. | |||
| %APHPUnit %s by Sebastian Bergmann and contributors. | |||
|
|
||
| (new PHPUnit\TextUI\Application)->run($_SERVER['argv']); | ||
| --EXPECTF-- | ||
| %APHPUnit %s by Sebastian Bergmann and contributors. |
|
"branch is already rebased onto upstream/10.5" conflicts with the target of this PR being |
|
Thanks for the quick review! |
joteejotee
force-pushed
the
fix/6097-testclass-file-attribute
branch
from
a5875eb to
bc5dffe
Compare
Use ReflectionClass to get actual class file path instead of method file path. Fixes sebastianbergmann#6097
joteejotee
force-pushed
the
fix/6097-testclass-file-attribute
branch
from
bc5dffe to
e16dc8c
Compare
|
Sorry about that — I forgot to include the changelog entry initially. I've now added it to ChangeLog-10.5.md following the project format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fileattribute of<testCaseClass>nodes in--list-tests-xmloutput was incorrect when test methods were inherited from abstract base classes. The file path pointed to the abstract class file instead of the concrete test class file.This fix uses
ReflectionClassto get the actual class file path instead of the method file path.Fixes #6097